fix: Add NAT Policies for Windows AKS-Swift Scenario #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaer-tsun
force-pushed
the
nat-dns-aksswift
branch
8 times, most recently
from
697c235 to
e530125
Compare
jaer-tsun
changed the title
jaer-tsun
force-pushed
the
nat-dns-aksswift
branch
from
e530125 to
04a2921
Compare
Contributor
|
@jaer-tsun Thanks for the PR, do you know what endpoints we use of the I just know that anything other than Edit: I guess it might just be |
Contributor
|
@tamilmani1989 can you take a peek at this PR? Basically we're saying now, that if CNI windows is Aks-Swift (aka, not multitenancy, and CNS as Ipam), then add two snat rules for IMDS and DNS Ips to be routed through the host |
jaer-tsun
force-pushed
the
nat-dns-aksswift
branch
from
04a2921 to
b5b21da
Compare
Member
|
@neaggarwMS @jaer-tsun can we set executionMode to AKS-Swift to determine if cni running in aks-swift or not.. instead of checking checking multitenancy and ipam type as azure-cns? |
jaer-tsun
force-pushed
the
nat-dns-aksswift
branch
from
b5b21da to
1200572
Compare
tamilmani1989
requested changes
Oct 14, 2021
rbtr
requested changes
Oct 15, 2021
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
minor syntactic and style things
jaer-tsun
force-pushed
the
nat-dns-aksswift
branch
4 times, most recently
from
d2b47ae to
80bb513
Compare
rbtr
previously requested changes
Oct 15, 2021
jaer-tsun
force-pushed
the
nat-dns-aksswift
branch
from
80bb513 to
0daa3ba
Compare
jaer-tsun
force-pushed
the
nat-dns-aksswift
branch
2 times, most recently
from
1de0c42 to
8c3e481
Compare
jaer-tsun
force-pushed
the
nat-dns-aksswift
branch
from
8c3e481 to
95f3b79
Compare
jaer-tsun
force-pushed
the
nat-dns-aksswift
branch
3 times, most recently
from
b71b461 to
ea08c12
Compare
jaer-tsun
force-pushed
the
nat-dns-aksswift
branch
from
ea08c12 to
e135969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding DNS & IMDS NAT Policy for Windows AKS-Swift Scenario
Issue Fixed:
Requirements:
Notes: