Remove lock files on reboot not needed #1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
force-pushed
the
tamanoha/lockfileopen
branch
from
b7d21a2 to
c06583b
Compare
tamilmani1989
force-pushed
the
tamanoha/lockfileopen
branch
2 times, most recently
from
f6f9a71 to
f8fdcf4
Compare
tamilmani1989
changed the title
tamilmani1989
force-pushed
the
tamanoha/lockfileopen
branch
2 times, most recently
from
04f52ec to
28214b0
Compare
ashvindeodhar
requested changes
Oct 1, 2021
jsturtevant
reviewed
Oct 1, 2021
|
|
||
| var lockFile *os.File | ||
| var err error | ||
| lockPerm := os.FileMode(0o664) + os.FileMode(os.ModeExclusive) |
Contributor
There was a problem hiding this comment.
was this value 0o664 valid?
Member
Author
There was a problem hiding this comment.
i corrected it to 0664 which is valid.
Collaborator
There was a problem hiding this comment.
@jsturtevant 0o644 is a legal (and unambiguous) representation of 0644, where the little o indicates octal
so
@tamilmani1989 you uncorrected it, 0o644 is less ambiguous and therefore preferred
Member
Author
There was a problem hiding this comment.
@rbtr oops. thanks for letting me know. i will revert this back
Contributor
|
xref: #774 this should resolve that issue partially |
Member
Author
not sure if this fixes that issue |
tamilmani1989
force-pushed
the
tamanoha/lockfileopen
branch
from
28214b0 to
c5b778a
Compare
Member
|
lgtm, you can merge once you get approval from Evan for filemode changes |
ashvindeodhar
previously approved these changes
Oct 1, 2021
tamilmani1989
force-pushed
the
tamanoha/lockfileopen
branch
from
c5b778a to
77e8ac9
Compare
rbtr
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
No need to remove lock files on reboot as like state files. This call causing unnecessary open to lock file.
Issue Fixed:
Requirements:
Notes: