[NPM] generic Policy Manager and some windows specific policy updates #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
commented
Oct 5, 2021
vakalapa
commented
Oct 5, 2021
Contributor
huntergregory
left a comment
huntergregory
left a comment
There was a problem hiding this comment.
updatePod() can be more efficient using the algorithm I designed, and I think we might have some disconnect with AddIPSetReferences()
| err := dp.ipsetMgr.AddReference(set.Name, netpolName, referenceType) | ||
| if err != nil { | ||
| return err | ||
| npmErrorString := npmerrors.AddSelectorReference |
Contributor
There was a problem hiding this comment.
I don't have a super strong preference, but can we consolidate these four lines into a function since it happens 4+ times?
| return nil | ||
| } | ||
|
|
||
| func (dp *DataPlane) addIPSetReferences(sets map[string]*ipsets.IPSet, netpolName string, referenceType ipsets.ReferenceType) error { |
Contributor
There was a problem hiding this comment.
can we rename this and deleteIPSetReferences? Maybe createIPSetsAndAddReference? Name is confusing with ipsetMgr.AddReference
huntergregory
approved these changes
Oct 6, 2021
Contributor
huntergregory
left a comment
huntergregory
left a comment
There was a problem hiding this comment.
we can address minor comments above in another PR
vakalapa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes following changes: