Support for Dualstack transparent #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
force-pushed
the
dualstack_transparent
branch
from
a2f2838 to
e67c8f8
Compare
fix compilation issues
tamilmani1989
force-pushed
the
dualstack_transparent
branch
from
e67c8f8 to
327fd04
Compare
vakalapa
reviewed
Oct 11, 2021
tamilmani1989
commented
Oct 11, 2021
tamilmani1989
force-pushed
the
dualstack_transparent
branch
2 times, most recently
from
5213ece to
2f96104
Compare
tamilmani1989
force-pushed
the
dualstack_transparent
branch
from
2f96104 to
c9a85fd
Compare
vakalapa
previously approved these changes
Oct 12, 2021
Contributor
vakalapa
left a comment
vakalapa
left a comment
There was a problem hiding this comment.
lgtm, thanks for adding the backlog item to cover these scenarios in AKS-e, this is a crucial gap we should fill in testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR adds support for dualstack transparent. v4 addresses will be from vnet and v6 addresses are non-vnet and retrieved from node ipam controller.
Abstracted out ExecuteCommand from platform so that unit test can be covered for these changes
Rename EPCommon package to networkutils package
Issue Fixed:
Requirements:
Notes: