-
Notifications
You must be signed in to change notification settings - Fork 260
[NPM] Adding prefixes to IPSets in dataplane #1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2b07c70
[NPM] Adding prefixes to IPSets in dataplane
e50f457
Correcting a linting issue
26ca48e
Using the correct case for metadata
652280f
Adding IOShim for both windows and linux
c07190e
splitting ioshim for each os
a83c87e
correcting a import error
dccfe2a
correcting some mistakes
e60626c
Adding tests for policies in Dp
7420d30
fixing a testname
1e852b4
merging master
c738678
Updating the dataplane mock file
2e1b5c9
removing dataplane mocks from dataplane tests as their scope is contr…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package common | ||
|
|
||
| import ( | ||
| testutils "github.com/Azure/azure-container-networking/test/utils" | ||
| utilexec "k8s.io/utils/exec" | ||
| ) | ||
|
|
||
| type IOShim struct { | ||
| Exec utilexec.Interface | ||
| } | ||
|
|
||
| func NewIOShim() *IOShim { | ||
| return &IOShim{ | ||
| Exec: utilexec.New(), | ||
| } | ||
| } | ||
|
|
||
| func NewMockIOShim(calls []testutils.TestCmd) *IOShim { | ||
| return &IOShim{ | ||
| Exec: testutils.GetFakeExecWithScripts(calls), | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package common | ||
|
|
||
| import ( | ||
| "github.com/Azure/azure-container-networking/network/hnswrapper" | ||
| testutils "github.com/Azure/azure-container-networking/test/utils" | ||
| utilexec "k8s.io/utils/exec" | ||
| ) | ||
|
|
||
| type IOShim struct { | ||
| Exec utilexec.Interface | ||
| Hns hnswrapper.HnsV2WrapperInterface | ||
| } | ||
|
|
||
| func NewIOShim() *IOShim { | ||
| return &IOShim{ | ||
| Exec: utilexec.New(), | ||
| Hns: &hnswrapper.Hnsv2wrapper{}, | ||
| } | ||
| } | ||
|
|
||
| func NewMockIOShim(calls []testutils.TestCmd) *IOShim { | ||
| return &IOShim{ | ||
| Exec: testutils.GetFakeExecWithScripts(calls), | ||
| Hns: &hnswrapper.Hnsv2wrapperFake{}, | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add the _windows suffix to this filename?