Skip to content

Conversation

@pjohnst5
Copy link
Contributor

Reason for Change:
In order to get cns to work as a host process pod on windows for AKS, these changes are necessary

@pjohnst5 pjohnst5 marked this pull request as ready for review November 17, 2021 20:38
tamilmani1989
tamilmani1989 previously approved these changes Nov 18, 2021
Copy link
Member

@tamilmani1989 tamilmani1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

author Paul Johnston <paujohns@microsoft.com> 1634166835 -0700
committer Paul Johnston <paujohns@microsoft.com> 1637019591 -0800

parent b1d7723
author Paul Johnston <paujohns@microsoft.com> 1634166835 -0700
committer Paul Johnston <paujohns@microsoft.com> 1637019572 -0800

feat: Exists() method on store

feat: config as flag to cns

feat: statefile path per OS

binary as os specific path

feat: Exists() method on store

feat: config as flag to cns

binary as os specific path
Copy link
Member

@tamilmani1989 tamilmani1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjohnst5 pjohnst5 merged commit 6d208e9 into Azure:master Nov 22, 2021
@pjohnst5 pjohnst5 deleted the cns-windows-aks branch November 22, 2021 17:23
@pjohnst5
Copy link
Contributor Author

image
Passed all but windows npm build, which was failing anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants