Use avast to retry init cns and register node. #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Nov 11, 2021
* stupid simple retry * go lint fixes * missed one // * avast retry * try out avast * vendor * try nad make linters happy * fix wrap check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
apiserver nnc might not be registered or api server might be down and crashloop backoff puts us outside of 5-10 minutes we have for aks addons to come up so retry a bit more aggresively here.
We could also exponential backoff here but wouldn't want ot go above 1 minute or we'd be in same place.
Use avast retry library in cns main so we don't hand roll our own.
This is the iron man bandaid version of #1084
Issue Fixed:
Requirements:
Notes: