Skip to content

Conversation

@JungukCho
Copy link
Contributor

@JungukCho JungukCho commented Nov 12, 2021

Reason for Change:

This PR is another series of refactoring translation.
This PR is mainly to clean-up unneeded codes and correct some bugs from previous PRs.

Issue Fixed:

Requirements:

Notes:

  1. [NPM] General translation logic for linux and windows [NPM] General translation logic for linux and windows #1055
  2. refactor: [NPM] parsing label selector for general translation logic refactor: [NPM] parsing label selector for general translation logic #1077

@JungukCho JungukCho added the npm Related to NPM. label Nov 12, 2021
Copy link
Contributor

@vakalapa vakalapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge this in once the UTs are green, rest of the pipeline tests do not apply on this PR changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm Related to NPM.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants