feat: [NPM] adding windows ACL Policy reset support #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
requested review from
JungukCho,
huntergregory and
matmerr
and removed request for
matmerr
| epIDs := dp.getAllEndpointIDs() | ||
|
|
||
| // It is important to keep order to clean-up ACLs before ipsets. Otherwise we won't be able to delete ipsets referenced by ACLs | ||
| if err := dp.policyMgr.Reset(epIDs); err != nil { |
Contributor
There was a problem hiding this comment.
in resetDataPlane(), only difference between linux and windows is getting the endpoint IDs. Perhaps make getAllEndpointIDs() OS specific (call dp.initializeDP() within it) and keep pMgr and iMgr resets in generic dp.Reset()
Contributor
Author
There was a problem hiding this comment.
We will also need to initializeDP first in windows to be able to get a view of the endpoints in HNS, so it would be better to keep it as is.
| // but if the bug is not solved then get all existing policies and remove relevant policies from list | ||
| // then apply remaining policies onto the endpoint | ||
| var aggregateErr error | ||
| noOfRulesToRemove := len(rulesToRemove) |
Contributor
There was a problem hiding this comment.
nitpick: more conventional to say numOfRules?
huntergregory
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding support to reset all existing NPM ACL policies on all endpoints in windows DP.
Issue Fixed:
Requirements:
Notes: