Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Nov 23, 2021

Reason for Change:

  • Standardize the language for the CNS IP pool:
    • "Allocated": all IPs that CNS has been allocated by DNC.
    • "Assigned": the IPs that CNS has assigned to specific Pods.
    • "Unassigned": allocated - assigned.
  • Defines additional data types for modelling IP pool information:
    • ipPoolState: is the live view of the IP pool; IPs allocated, assigned, requested, available, pendingProgramming, pendingRelease, unavailable, notInUse.
    • metaState: holds pool metadata: the batch size, max size, and min/max free.
    • adds helper methods to build this state from a single query of the CNS pool singleton instead of several locking calls.
  • Upcast all the numerics in the pool Monitor to int64 to stop converting and comparing back and forth between int/int64
  • Update the IPAM metrics to align with these changes.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr added the cns Related to CNS. label Nov 23, 2021
@rbtr rbtr force-pushed the fix/assigned-vs-allocated branch 3 times, most recently from bd553bf to 14fbcf7 Compare November 24, 2021 04:12
@rbtr rbtr requested a review from rsagasthya November 24, 2021 22:10
@rbtr rbtr force-pushed the fix/assigned-vs-allocated branch from 14fbcf7 to e79f2b1 Compare November 30, 2021 01:24
@rbtr rbtr requested a review from thatmattlong November 30, 2021 01:45
rbtr added 6 commits November 30, 2021 14:20
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>

typo
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr force-pushed the fix/assigned-vs-allocated branch from f2ba571 to bacbbc5 Compare November 30, 2021 20:20
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr force-pushed the fix/assigned-vs-allocated branch from 067a7c2 to 7cc1297 Compare November 30, 2021 22:52
thatmattlong
thatmattlong previously approved these changes Nov 30, 2021
@rbtr
Copy link
Collaborator Author

rbtr commented Dec 1, 2021

@huntergregory @thatmattlong what happened?

@huntergregory
Copy link
Contributor

@huntergregory @thatmattlong what happened?

Not sure what it means by this:

huntergregory dismissed thatmattlong’s stale review via 7cc1297 17 hours ago

I made some commits to #1138 last night, but why would that impact this?

@rbtr
Copy link
Collaborator Author

rbtr commented Dec 1, 2021

Unclear...GitHub thinks you pushed a commit to this branch I think? @thatmattlong no change since your review, do you mind stamping it again

@rbtr rbtr requested a review from thatmattlong December 1, 2021 18:49
@rbtr rbtr merged commit a8ba90e into Azure:master Dec 2, 2021
@rbtr rbtr deleted the fix/assigned-vs-allocated branch December 2, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cns Related to CNS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants