-
Notifications
You must be signed in to change notification settings - Fork 260
Update IPAM pool monitor's pool state logic and language #1126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd553bf to
14fbcf7
Compare
14fbcf7 to
e79f2b1
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> typo
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
f2ba571 to
bacbbc5
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
067a7c2 to
7cc1297
Compare
thatmattlong
previously approved these changes
Nov 30, 2021
Collaborator
Author
|
@huntergregory @thatmattlong what happened? |
Contributor
Not sure what it means by this:
I made some commits to #1138 last night, but why would that impact this? |
Collaborator
Author
|
Unclear...GitHub thinks you pushed a commit to this branch I think? @thatmattlong no change since your review, do you mind stamping it again |
thatmattlong
approved these changes
Dec 1, 2021
matmerr
reviewed
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
ipPoolState: is the live view of the IP pool; IPs allocated, assigned, requested, available, pendingProgramming, pendingRelease, unavailable, notInUse.metaState: holds pool metadata: the batch size, max size, and min/max free.Issue Fixed:
Requirements:
Notes: