fix: [NPM] v2 backwards compatibility #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
vakalapa
previously approved these changes
Dec 7, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vakalapa
reviewed
Dec 8, 2021
| // and flushes and deletes all NPM Chains. | ||
| func (pMgr *PolicyManager) removeNPMChains() error { | ||
| // 1.1 delete the deprecated jump rule from FORWARD chain to AZURE-NPM chain, if it exists | ||
| deprecatedDeleteErrCode, deprecatedDeleteErr := pMgr.runIPTablesCommand(util.IptablesDeletionFlag, deprecatedJumpFromForwardToAzureChainArgs...) |
Contributor
There was a problem hiding this comment.
Does this mean we will suppress any other kind of error without log ? we should at least log it!
Contributor
Author
There was a problem hiding this comment.
Oh, I meant to do the negated version of that boolean. Updating to do a switch statement for all possible error codes
vakalapa
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the old jump to azure chain (without ctstate new) so that we can destroy azure chain on reset.
Prior to this fix, deploying v2 after v1 caused a CrashLoopBackOff.