fix: [NPM] wait for Azure network to be created in windows DP for 20 … #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| } | ||
|
|
||
| func (dp *DataPlane) getNetworkInfo() error { | ||
| err := dp.setNetworkIDByName(AzureNetworkName) |
Contributor
There was a problem hiding this comment.
We can remove the if-statement and all other code outside of it because the ticker starts right away (if I'm not mistaken)
Contributor
Author
There was a problem hiding this comment.
Ticker by default does not start right away, had to change it up a bit.
huntergregory
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mins
Reason for Change:
Currently when an AKS-e cluster is created, "azure" HNS network is not created right away. Only after pods are scheduled will "azure" network be created. Making change in NPM to not error out right away and wait 20 mins and retry for azure network info.
Issue Fixed:
Requirements:
Notes: