perf: [NPM] cut latency in half for v2 applyIPSets #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
reviewed
Dec 16, 2021
| ipsetIPPortHashString = ipsetIPPortHashFlag | ||
| lengthForSuccessfulMatch = 2 | ||
| createStringWithSpace = "create " | ||
| lenCreateStringWithSpace = len(createStringWithSpace) |
Contributor
There was a problem hiding this comment.
We only use these lengths once right ? do we need constants for that ?
Contributor
Author
There was a problem hiding this comment.
removed these
| lineAfterAdd := string(line[lenAddStringWithSpace:]) | ||
| spaceSplitLineAfterAdd := strings.Split(lineAfterAdd, space) | ||
| parent := spaceSplitLineAfterAdd[0] | ||
| fmt.Println("DEBUGME", prefixedName, parent, hashedName) |
Contributor
There was a problem hiding this comment.
you might want to clean these later ?
vakalapa
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Estimated 50-75% improvement in latency from experiments. Previously used regex and now use strings to parse ipset save files.
Hoping to reduce memory usage as well by not using regex.