Skip to content

fix: [NPM] fix Windows build errors #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2022
Merged

fix: [NPM] fix Windows build errors #1183

merged 1 commit into from
Jan 4, 2022

Conversation

@huntergregory
Copy link
Contributor

@huntergregory huntergregory commented Dec 30, 2021

This PR doesn't try to fix UT errors for Windows that existed before #1150.

@huntergregory huntergregory added the npm Related to NPM. label Dec 30, 2021
@vakalapa vakalapa merged commit e997e75 into master Jan 4, 2022
@vakalapa vakalapa deleted the fix-npm-build-error branch January 4, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vakalapa vakalapa vakalapa approved these changes

Assignees

No one assigned

Labels

npm Related to NPM.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huntergregory @vakalapa