feat: [NPM] GoalState processor for Daemon pod #1187
Conversation
| dp.DeleteIPSet(ipsets.TestKVPodSet.Metadata) | ||
| panicOnError(dp.ApplyDataPlane()) | ||
|
|
||
| panicOnError(dp.AddToLists([]*ipsets.IPSetMetadata{ipsets.TestNestedLabelList.Metadata}, []*ipsets.IPSetMetadata{ipsets.TestKVPodSet.Metadata, ipsets.TestNSSet.Metadata})) |
There was a problem hiding this comment.
can you surround this in an if statement (if includeLists or something like other list operations in the file)
There was a problem hiding this comment.
It is a validate test case we should use always right ? Any particular reason for this suggestion ?
There was a problem hiding this comment.
My machine doesn't support lists, so I introduced includeLists
npm/pkg/dataplane/ipsets/ipset.go
Outdated
| } | ||
|
|
||
| func (set *IPSet) GetSetMetadata() *IPSetMetadata { | ||
| return NewIPSetMetadata(set.unPrefixedName, set.Type) |
There was a problem hiding this comment.
why do we want the unprefixed name for this?
There was a problem hiding this comment.
Metadata of a ipset should always be created with unprefixed name, or else we will end up using double prefixed names.
| type GenericDataplane interface { | ||
| InitializeDataPlane() error | ||
| ResetDataPlane() error | ||
| GetIPSet(setName string) *ipsets.IPSet |
There was a problem hiding this comment.
As discussed offline, I feel this shouldn't be part of the generic dataplane interface. Perhaps the gsp should use the dataplane struct instead of the GenericDataplane interface
There was a problem hiding this comment.
This is a function we will need for DPmocks for UTs and also for GSProcessor. So kept it as a higher level interface method. In future, we can this function for other utilities, like debugging or observability.
There was a problem hiding this comment.
So is this a no-op in production?
There was a problem hiding this comment.
GetIPSet is being used by GSProcessors, DP, to figure out what is existing set goal state and to compute diff. We are also using this in UTs.
Atm, we do not use this function in normal coupled mode.
| return | ||
| } | ||
|
|
||
| err := gsp.processIPSetsApplyEvent(payload[cp.IpsetApply]) |
There was a problem hiding this comment.
Check if key exists? We don't want to panic if the event payload doesn't contain the key.
There was a problem hiding this comment.
I am a little confused by these process blocks. Does every incoming payload have all keys in the map populated?
There was a problem hiding this comment.
For NameSpace resource events:
Add: IPSETAPPLY
Update/Delete: IPSETAPPLY and /(or) IPSETREMOVE
For Pod resource events:
Add: IPSETAPPLY
Update/Delete: IPSETAPPLY and /(or) IPSETREMOVE
For Network Policy resource events:
Add: IPSETAPPLY and PolicyAPPly
Update: IPSETAPPLY and /(or) IPSETREMOVE + PolicyAPPLY
Delete: IPSETREMOVE + PolicyRemove
This is how the keys will match to respective resource events ... @huntergregory FYI
| type GenericDataplane interface { | ||
| InitializeDataPlane() error | ||
| ResetDataPlane() error | ||
| GetIPSet(setName string) *ipsets.IPSet |
There was a problem hiding this comment.
So is this a no-op in production?
| outChannel chan *protos.Events | ||
| } | ||
|
|
||
| func NewDPSim(outChannel chan *protos.Events) *DPShim { |
Reason for Change:
Issue Fixed:
Requirements:
Notes: