feat: [NPM] Create controlplane manager for decomposed model #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
reviewed
Jan 10, 2022
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
nitishm
force-pushed
the
nitishm/feat/decomposed-model-start-commands
branch
from
6c87214 to
2dba673
Compare
nitishm
commented
Jan 10, 2022
nitishm
commented
Jan 10, 2022
nitishm
commented
Jan 10, 2022
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
nitishm
force-pushed
the
nitishm/feat/decomposed-model-start-commands
branch
from
ad1a8eb to
e66192e
Compare
vakalapa
reviewed
Jan 13, 2022
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
matmerr
reviewed
Jan 14, 2022
nitishm
changed the title
…rking into nitishm/feat/decomposed-model-start-commands
- Completed the TODO items including instantiating the goalstateprocessor and passing it to the controllers - Refactor of the code and add error/corner condition checks to all initializers. Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
nitishm
changed the title
nitishm
force-pushed
the
nitishm/feat/decomposed-model-start-commands
branch
from
ed9039a to
1cd7e7a
Compare
nitishm
force-pushed
the
nitishm/feat/decomposed-model-start-commands
branch
from
1cd7e7a to
ce9e0d7
Compare
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
nitishm
force-pushed
the
nitishm/feat/decomposed-model-start-commands
branch
from
ce9e0d7 to
292233c
Compare
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
nitishm
force-pushed
the
nitishm/feat/decomposed-model-start-commands
branch
from
9165153 to
dfe028b
Compare
nitishm
changed the title
vakalapa
requested changes
Jan 18, 2022
Contributor
vakalapa
left a comment
vakalapa
left a comment
There was a problem hiding this comment.
Initial component naming comments.
nitishm
force-pushed
the
nitishm/feat/decomposed-model-start-commands
branch
from
353cbdd to
9809b1b
Compare
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
nitishm
force-pushed
the
nitishm/feat/decomposed-model-start-commands
branch
from
9809b1b to
b203866
Compare
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
…rking into nitishm/feat/decomposed-model-start-commands
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
vakalapa
reviewed
Jan 19, 2022
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
Signed-off-by: Nitish Malhotra <nitishm@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the controlplane component of the decomposed model of
operation.
controllers
Signed-off-by: Nitish Malhotra nitishm@microsoft.com
Reason for Change:
Issue Fixed:
Requirements:
Notes: