Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Jan 10, 2022

Signed-off-by: Evan Baker rbtr@users.noreply.github.com

Reason for Change:

Fixes potential race condition where, since NNCs are named using the Node name:

  • a Node named X could be deleted,
  • its NNC might not (yet) be garbage collected,
  • CNS starting on a new Node also named X might fetch that stale NNC and assign IPs from it.

this could result in IP leaks/pod connectivity disruptions when the stale NNC eventually gets GC'd and the new one for that node is created.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr self-assigned this Jan 11, 2022
@rbtr rbtr force-pushed the cns/feat/node-uid-xref branch 2 times, most recently from 4ef4c9f to 6b43a9a Compare January 28, 2022 22:50
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr force-pushed the cns/feat/node-uid-xref branch from 6b43a9a to ae54c5f Compare January 28, 2022 22:54
@rbtr rbtr merged commit 80e574b into Azure:master Jan 29, 2022
@rbtr rbtr deleted the cns/feat/node-uid-xref branch January 29, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants