fix: [NPM] Windows Dataplane logic fix for src and dst ports #1197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
According to the newly found info in VFP, the src and dst port mapping we used earlier are wrong. So correcting the logic as per below mapping:
// HNS has confusing Local and Remote address defintions
// For Traffic Direction INGRESS
// LocalAddresses = Source Sets
// RemoteAddresses = Destination Sets
// LocalPorts = Destination Ports
// RemotePorts = Source Ports
// For Traffic Direction EGRESS
// LocalAddresses = Source Sets
// RemoteAddresses = Destination Sets
// LocalPorts = Source Ports
// RemotePorts = Destination Ports
// If we use IPs in ACLs, then INGRESS mapping is same, but EGRESS mapping will change to below
// For Traffic Direction INGRESS
// LocalAddresses = Source IPs
// RemoteAddresses = Destination IPs
// For Traffic Direction EGRESS
// LocalAddresses = Destination IPs
// RemoteAddresses = Source IPs
Issue Fixed:
Requirements:
Notes: