Skip to content

Conversation

@vakalapa
Copy link
Contributor

@vakalapa vakalapa commented Jan 18, 2022

Reason for Change:

According to the newly found info in VFP, the src and dst port mapping we used earlier are wrong. So correcting the logic as per below mapping:

// HNS has confusing Local and Remote address defintions
// For Traffic Direction INGRESS
// LocalAddresses = Source Sets
// RemoteAddresses = Destination Sets
// LocalPorts = Destination Ports
// RemotePorts = Source Ports

// For Traffic Direction EGRESS
// LocalAddresses = Source Sets
// RemoteAddresses = Destination Sets
// LocalPorts = Source Ports
// RemotePorts = Destination Ports

// If we use IPs in ACLs, then INGRESS mapping is same, but EGRESS mapping will change to below
// For Traffic Direction INGRESS
// LocalAddresses = Source IPs
// RemoteAddresses = Destination IPs
// For Traffic Direction EGRESS
// LocalAddresses = Destination IPs
// RemoteAddresses = Source IPs

Issue Fixed:

Requirements:

Notes:

nitishm
nitishm previously approved these changes Jan 18, 2022
Copy link
Contributor

@nitishm nitishm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

policySettings.LocalPorts = dstPortStr
policySettings.RemotePorts = ""
policySettings.RemoteAddresses = srcListStr
policySettings.LocalPorts = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do something for IP mode too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we have de-prioritized IpMode. No need to do it.

@vakalapa vakalapa merged commit 1f211a7 into master Jan 26, 2022
@vakalapa vakalapa deleted the vakr/windpcorrections branch January 26, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants