Skip to content

Server-side filtering for NodeNetworkConfig, Node, and Pod objects #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Server-side filtering for NodeNetworkConfig, Node, and Pod objects #1198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1155631
server-side filtering for nnc objects
rbtr Jan 19, 2022
32bdad4
yagni node and pod fields in cache builder
rbtr Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions cns/service/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ import (
"github.com/Azure/azure-container-networking/store"
"github.com/avast/retry-go/v3"
"github.com/pkg/errors"
"k8s.io/apimachinery/pkg/fields"
"k8s.io/apimachinery/pkg/types"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/cache"
"sigs.k8s.io/controller-runtime/pkg/client"
)

Expand Down Expand Up @@ -932,10 +934,22 @@ func InitializeCRDState(ctx context.Context, httpRestService cns.HTTPService, cn
return err
}

// the nodeScopedCache sets Selector options on the Manager cache which are used
// to perform *server-side* filtering of the cached objects. This is very important
// for high node/pod count clusters, as it keeps us from watching objects at the
// whole cluster scope when we are only interested in the Node's scope.
nodeScopedCache := cache.BuilderWithOptions(cache.Options{
SelectorsByObject: cache.SelectorsByObject{
&v1alpha.NodeNetworkConfig{}: {
Field: fields.SelectorFromSet(fields.Set{"metadata.name": nodeName}),
},
},
})
manager, err := ctrl.NewManager(kubeConfig, ctrl.Options{
Scheme: nodenetworkconfig.Scheme,
MetricsBindAddress: cnsconfig.MetricsBindAddress,
Namespace: "kube-system", // TODO(rbtr): namespace should be in the cns config
NewCache: nodeScopedCache,
})
if err != nil {
return errors.Wrap(err, "failed to create manager")
Expand Down