fix: [NPM] fix incorrect ipset create, fix 1-off prometheus logic, and add cache checking for UTs #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

huntergregory merged 11 commits into master from ipsetmanager-bug-fix-and-UTs

Feb 1, 2022

Contributor

huntergregory commented Jan 21, 2022 •

edited

Loading

Fixes a bug where a set would be created if it doesn't exist and Delete member API call is made on the set.

Adds exec time metrics for applying ipsets and adding ACL rules.

Did the following UTs:

apply sets
create set
delete set
add to set

Need to eventually do:

delete from set
add to list
delete from list
add/delete selector

wip

dc21ec2

huntergregory added the npm label

huntergregory requested a review from vakalapa

January 21, 2022 02:10

huntergregory commented

View reviewed changes

npm/metrics/prometheus-metrics.go Show resolved Hide resolved

huntergregory added 2 commits

January 25, 2022 17:54


          dont touch v1 metrics code and fix lints

fe81c79


          add comment and comment code to resolve lint

aff520c

huntergregory marked this pull request as ready for review

January 26, 2022 02:08

Contributor Author

huntergregory commented Jan 26, 2022

/azp run

azure-pipelines bot commented Jan 26, 2022

Azure Pipelines successfully started running 2 pipeline(s).

vakalapa reviewed

View reviewed changes

npm/pkg/dataplane/ipsets/ipsetmanager.go Show resolved Hide resolved

npm/pkg/dataplane/ipsets/ipsetmanager.go Outdated Show resolved Hide resolved

huntergregory mentioned this pull request

feat: [NPM] Adding DPShim layer in controller pods #1206

Merged

3 tasks


          optimize looping and dirty cache updates

4d68949

vakalapa reviewed

View reviewed changes

npm/pkg/dataplane/ipsets/ipsetmanager.go Outdated Show resolved Hide resolved

vakalapa reviewed

View reviewed changes

npm/pkg/dataplane/ipsets/ipsetmanager.go Outdated Show resolved Hide resolved

vakalapa reviewed

View reviewed changes

npm/pkg/dataplane/ipsets/ipsetmanager.go Outdated Show resolved Hide resolved

vakalapa reviewed

View reviewed changes

npm/pkg/dataplane/ipsets/ipsetmanager.go Outdated Show resolved Hide resolved

huntergregory added 5 commits

January 27, 2022 15:25


          address comments and change param type of modifyCacheForKernelMemberU…

f9bc5e8

…pdate to reduce map lookups


          Merge branch 'master' into ipsetmanager-bug-fix-and-UTs

00bd755


          add exec time metrics

6e71db9

UTs

00fc589


          fix lints

4ae8e86

vakalapa reviewed

View reviewed changes

npm/pkg/dataplane/ipsets/ipsetmanager.go Show resolved Hide resolved


          initialize metrics in policymanager tests

ef03e40

vakalapa previously approved these changes

View reviewed changes

Contributor

vakalapa commented Feb 1, 2022

@huntergregory V2 conformance is failing consistently.

Contributor Author

huntergregory commented Feb 1, 2022

@huntergregory V2 conformance is failing consistently.

investigating

Contributor Author

huntergregory commented Feb 1, 2022

/azp run

azure-pipelines bot commented Feb 1, 2022

Azure Pipelines successfully started running 2 pipeline(s).

huntergregory dismissed vakalapa’s stale review via

7d2be89

February 1, 2022 19:17


          fix bug in publishing npm logs

7d2be89

vakalapa approved these changes

View reviewed changes

huntergregory merged commit 667743d into master

huntergregory deleted the ipsetmanager-bug-fix-and-UTs branch

February 1, 2022 22:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npm