Adding CniSucceeded flag to report whether CNI had been run successfully. #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiyan86
suggested changes
Apr 26, 2018
Contributor
saiyan86
left a comment
saiyan86
left a comment
There was a problem hiding this comment.
Also remove the binary file.
|
|
||
| if err != nil { | ||
| os.Exit(1) | ||
| } else { |
cni/network/plugin/main.go
Outdated
| // Report CNI successfully finished execution. | ||
| reportManager.Report.CniSucceeded = true | ||
| err = reportManager.SendReport() | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
if reportManager.SendReport() != nil
Contributor
Author
There was a problem hiding this comment.
we're printing the error out though...
saiyan86
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a CniSucceeded flag as part of the telemetry report set to HostNetAgent.