fix: [NPM] rename string methods #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
previously approved these changes
Feb 11, 2022
huntergregory
force-pushed
the
npm-pretty-string
branch
from
073654c to
bb5087c
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
matmerr
approved these changes
Feb 17, 2022
Member
matmerr
left a comment
matmerr
left a comment
There was a problem hiding this comment.
ty for doing this, makes investigations easier :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String() --> PrettyString()
The NPMNetworkPolicy.String() method was not implicitly used in any printing or logging in the dataplane/ or dataplane/policies/ folders or in v2 networkPolicyController.