Subnet labels #1238
Merged
Subnet labels #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsagasthya
force-pushed
the
subnet-labels
branch
from
7d6ba60 to
32b6d5d
Compare
…nd remove a whitespace.
rbtr
requested changes
Feb 18, 2022
cns/ipampool/metrics.go
Outdated
Comment on lines
9
to
10
| subnetLabel = "Subnet" | ||
| subnetCIDRLabel = "SubnetCIDR" |
rsagasthya
force-pushed
the
subnet-labels
branch
from
d98c19e to
40e4b21
Compare
rbtr
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Needed to add dimensions to the CNS Metrics.
Issue Fixed:
Added Subnet Name and Subnet Address Space as subnet and subnet_cidr dimensions.
Requirements:
Notes: