fix: [NPM] disable v2 CLI & polish linux policy manager #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
reviewed
Feb 16, 2022
| // ACN CLI debug handlerss | ||
| // TODO support the debug CLI for v2 | ||
| // the nil check is for fan-out npm | ||
| if config.Toggles.EnableHTTPDebugAPI && npmEncoder != nil && !config.Toggles.EnableV2NPM { |
Contributor
There was a problem hiding this comment.
Why do we need to disable GetCache for V2, this is useful irrespective of debug CLI.
Contributor
Author
There was a problem hiding this comment.
currently the cache is buggy for v2. Let's fix this in another PR
| /* | ||
| Error handling for iptables-restore: | ||
| Currently we retry on any error and will make two tries max. | ||
| The section IDs and line error patterns are pointless currently. Although we can eventually use them to skip a section with an error and salvage the rest of the file. |
Contributor
There was a problem hiding this comment.
nit: Can you reduce this oneline into two, its too long.
Contributor
Author
There was a problem hiding this comment.
addressing in followup PR
vakalapa
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: