feat: [NPM] lazy delete ipsets #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
reviewed
Feb 24, 2022
| // NOTE: in ApplyAllIPSets mode, if this ipset has never been created in the kernel, it would be added to the deleteCache, and then the OS would fail to delete it | ||
| iMgr.modifyCacheForKernelRemoval(set.Name) | ||
| } | ||
| // if mode is ApplyOnNeed, the set will not be in the kernel (or will be in the delete cache already) since there are no references |
Contributor
There was a problem hiding this comment.
Even in applyONNeed we might end in situation where a set is needed with members and then we delete the referenced netpol/list. We can end up with empty sets in kernel right ?
Contributor
Author
There was a problem hiding this comment.
anytime the set is modified, we see if it should be in the kernel now, and it to the deleteCache if needed
vakalapa
reviewed
Feb 25, 2022
vakalapa
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place the burden of cleaning up empty/unreferenced ipsets on the dataplane. The ipset manager will remove all deletable sets from the main cache, and for
ApplyAllIPSetsmode, will add those sets to thetoDeleteCache, ready to be removed on the nextApplyIPSetscall.This PR does the following:
DeleteIPSetcalls from the controllers:Namespaceipsets in namespace controllerMinor updates: