Skip to content

Conversation

@rsagasthya
Copy link
Contributor

Added Pod Net Arm Id as labels to the CNS Metrics.

Reason for Change:

Issue Fixed:

Requirements:

Notes:

Added Pod Net Arm Id as labels to the CNS Metrics.
@rsagasthya rsagasthya requested a review from rbtr February 28, 2022 18:31
Necessary changes to the read the ARM ID metadata coming from DNC.
Variable names had to be modified to meet lint standards.
Variable names had to be modified to meet lint standards.
NNC that was passed to create the ARM ID was too heavy. Converted that argument to a pointer and passed the reference of the NNC in that method.
Added the "cx_" prefix to prometheus metrics of CNS.
Minor edits with the Metric Names and Documentation.
Made changes to the ConstLabels in the CNS Metrics.
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rsagasthya rsagasthya enabled auto-merge (squash) March 16, 2022 00:38
@rsagasthya rsagasthya merged commit 65ce2f1 into Azure:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants