Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Mar 8, 2022

Signed-off-by: Evan Baker rbtr@users.noreply.github.com

Reason for Change:

Fixes a regression since CNI 1.4.13 where the IPTables chains were set in the opts map, then that opts map was thrown away and an empty opts map was used in the function that execs IPTables with the contents of the opts map.

Issue Fixed:

Requirements:

Notes:

Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr changed the title pass the populated opts in instead of overwriting with empty map pass the populated IPTables opts instead of overwriting with empty map Mar 8, 2022
Copy link
Member

@tamilmani1989 tamilmani1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@csfmomo
Copy link
Contributor

csfmomo commented Mar 9, 2022

checking

@csfmomo
Copy link
Contributor

csfmomo commented Mar 9, 2022

nvm

@rbtr rbtr enabled auto-merge (squash) March 10, 2022 17:55
@rbtr rbtr disabled auto-merge March 10, 2022 17:55
@rbtr rbtr merged commit 25d47e2 into Azure:master Mar 10, 2022
@rbtr rbtr deleted the fix/swift-iptables branch March 10, 2022 17:55
@rbtr rbtr added the cni Related to CNI. label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cni Related to CNI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants