update to go1.18 #1281
Merged
update to go1.18 #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timraymond
previously approved these changes
Mar 16, 2022
Member
timraymond
left a comment
timraymond
left a comment
There was a problem hiding this comment.
Looks good, thanks for jumping right on the upgrade 🎉
rbtr
force-pushed
the
chore/go1.18
branch
2 times, most recently
from
c086f09 to
7016ff0
Compare
rbtr
force-pushed
the
chore/go1.18
branch
3 times, most recently
from
31675c1 to
4bc8849
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Collaborator
Author
|
@vakalapa are the NPM conformance test failures here something to be concerned about, or flakes? |
Contributor
Should be okay, this seems to be a flake test failure. |
vakalapa
approved these changes
Apr 4, 2022
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change:
Issue Fixed:
Requirements:
Notes: