move mode to NC and add type #1331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatmattlong
previously approved these changes
Apr 14, 2022
neaggarwMS
requested changes
Apr 14, 2022
| ID string `json:"id,omitempty"` | ||
| ID string `json:"id,omitempty"` | ||
| // +kubebuilder:default=dynamic | ||
| Mode IPAMMode `json:"mode,omitempty"` |
Member
There was a problem hiding this comment.
Lets call it ScalerMode as we discussed
| type NCType string | ||
|
|
||
| const ( | ||
| VNET NCType = "vnet" // swift |
Member
There was a problem hiding this comment.
Remove //swift comment. both overlay and vnet are swift types only
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr
added
cns
neaggarwMS
approved these changes
Apr 14, 2022
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change:
Issue Fixed:
Requirements:
Notes: