CNI Linux: Add 10 seconds timeout for ExecuteCommand #1336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msvik
force-pushed
the
cnilivesiterepair
branch
from
809d45d to
d727406
Compare
added 2 commits
April 19, 2022 09:59
Collaborator
|
Any reason to do this only for linux and not windows? |
Contributor
Author
The livesite was seen/debugged in Linux CNI. Second, Tamilmani pointed out that his observation is that these system commands finish much faster in Linux (order of couple of seconds) and on windows take longer anyway. So, it is just safer to add timeout to Linux. |
Member
In addition to what vipin said, in windows we use hns calls lot than exec cmds. we have a repair item to add timeout for hns calls |
tamilmani1989
requested changes
Apr 20, 2022
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
* CNI Linux: Add 10 seconds timeout for ExecuteCommand * ran gofmt on changed file * Fix lint error * Added unit test for ExecuteCommand for linux * Moved timeout to execlient. It has default timeout and method to override it now * reduce timeout values in unit tests Co-authored-by: msvik <msvik@users.noreply.github.com> Co-authored-by: VK <misvik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Currently when CNI does a system call, it doesn't have a timeout. It sometimes hangs or waits a long time before it fails leading to other CNI instances getting blocked. This PR adds 10 second timeout for system calls so CNI can timeout and let other CNI instances get through it.
Issue Fixed:
It fixes the live site repair item ADO # 13142210.
Requirements:
Notes: