build: Add Windows CNS & NPM as Part of Multi-Arch Manifest #1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaer-tsun
force-pushed
the
buildWindowsImages
branch
from
19ee386 to
18d5d3f
Compare
rbtr
requested changes
Apr 21, 2022
jaer-tsun
force-pushed
the
buildWindowsImages
branch
from
18d5d3f to
a49eb87
Compare
jaer-tsun
force-pushed
the
buildWindowsImages
branch
11 times, most recently
from
1e0ad33 to
08d3863
Compare
jaer-tsun
force-pushed
the
buildWindowsImages
branch
4 times, most recently
from
f84d064 to
5ea252b
Compare
jaer-tsun
changed the title
jaer-tsun
force-pushed
the
buildWindowsImages
branch
2 times, most recently
from
533fe38 to
5917a30
Compare
jaer-tsun
force-pushed
the
buildWindowsImages
branch
4 times, most recently
from
a4b24df to
63ad27c
Compare
jaer-tsun
force-pushed
the
buildWindowsImages
branch
from
63ad27c to
3edce81
Compare
rbtr
approved these changes
May 4, 2022
Comment on lines
-139
to
-140
| - template: windows-image.yaml | ||
|
|
Collaborator
|
@Azure/acn-npm-reviewers for npm failures here? |
rbtr
approved these changes
May 5, 2022
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
lgtm pending npm check failures
rsagasthya
pushed a commit
to rsagasthya/azure-container-networking
that referenced
this pull request
May 18, 2022
* add windows cns manifest to multi arch image * try to use generic windows template w/ containerize stage in pipeline * try and use buildah to pull images * update manifest build and push for buildah * create manifest by referencing images instead of pulling to avoid OS mismatch error * remove unused windows-image.yaml * remove REGISTRY var and use IMAGE_REGISTRY from makefile Co-authored-by: Jaeryn <tsun.chu@microsoft.com> Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
* add windows cns manifest to multi arch image * try to use generic windows template w/ containerize stage in pipeline * try and use buildah to pull images * update manifest build and push for buildah * create manifest by referencing images instead of pulling to avoid OS mismatch error * remove unused windows-image.yaml * remove REGISTRY var and use IMAGE_REGISTRY from makefile Co-authored-by: Jaeryn <tsun.chu@microsoft.com> Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Adding windows cns to multi arch image to support windows AKS-Swift
Issue Fixed:
Requirements:
Notes: