Add Cyclonus Windows job #1363
Merged
Add Cyclonus Windows job #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaer-tsun
reviewed
May 4, 2022
| set -xv | ||
|
|
||
| cyclonusProfile="./install-cyclonus.yaml" | ||
| if [ -z "$1" == "windows"] |
Contributor
There was a problem hiding this comment.
is the -z to check $1 is empty before comparison?
matmerr
force-pushed
the
cyclonuswindowsjob
branch
11 times, most recently
from
3dae0f7 to
0f588a8
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
matmerr
force-pushed
the
cyclonuswindowsjob
branch
3 times, most recently
from
fe28fdd to
d13bcd2
Compare
matmerr
force-pushed
the
cyclonuswindowsjob
branch
from
aef57e4 to
1a5135e
Compare
| --name awin22 \ | ||
| --os-type Windows \ | ||
| --os-sku Windows2022 \ | ||
| --node-count 1 |
| az aks get-credentials -g $CLUSTER_NAME -n $CLUSTER_NAME --overwrite-existing | ||
| - task: AzureCLI@2 | ||
| displayName: "Deploy NPM to Test Cluster" |
Contributor
There was a problem hiding this comment.
task above has same name
| ./kubectl --kubeconfig=./kubeconfig set image daemonset/azure-npm -n kube-system azure-npm=$IMAGE_REGISTRY/azure-npm:linux-amd64-$(TAG) | ||
| # swap NPM profile with one specified as parameter | ||
| ./kubectl --kubeconfig=./kubeconfig apply -f https://raw.githubusercontent.com/Azure/azure-container-networking/master/npm/profiles/$(PROFILE).yaml |
Contributor
There was a problem hiding this comment.
for ws22, having PROFILE as "v2-default-ws22" has unintended effect of failing to apply a configmap here
| ./kubectl --kubeconfig=./kubeconfig set image daemonset/azure-npm -n kube-system azure-npm=$IMAGE_REGISTRY/azure-npm:windows-amd64-$(TAG) | ||
| # swap NPM profile with one specified as parameter | ||
| ./kubectl --kubeconfig=./kubeconfig apply -f |
Contributor
There was a problem hiding this comment.
not applying any file here. Should probably do the following steps:
- apply both linux and windows yaml
- swap profile
- restart both win and linux ds
| chmod +x kubectl | ||
| # deploy azure-npm | ||
| ./kubectl --kubeconfig=./kubeconfig apply -f https://raw.githubusercontent.com/Azure/azure-container-networking/master/npm/azure-npm.yaml |
Contributor
There was a problem hiding this comment.
add windows yaml too in case it's the ws22 matrix strat
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| export CLUSTER_NAME=$(RESOURCE_GROUP)-$(PROFILE) | ||
| echo "Creating resource group named $CLUSTER_NAME" | ||
| az group create --name $CLUSTER_NAME -l $(LOCATION) -o table |
Contributor
There was a problem hiding this comment.
is location ever set?
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
matmerr
force-pushed
the
cyclonuswindowsjob
branch
from
9a0f720 to
20cf2c5
Compare
matmerr
force-pushed
the
cyclonuswindowsjob
branch
from
6a4c64d to
4d311ca
Compare
matmerr
force-pushed
the
cyclonuswindowsjob
branch
from
4d311ca to
c51063c
Compare
matmerr
force-pushed
the
cyclonuswindowsjob
branch
from
9a2ece7 to
a241da5
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vakalapa
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Need to run cyclonus on Windows pipelines
Issue Fixed:
Requirements:
Notes: