Fix CNS Reconciling and AssignmentMode handling for AKS Swift #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neaggarwMS
changed the title
rbtr
approved these changes
May 13, 2022
rsagasthya
pushed a commit
to rsagasthya/azure-container-networking
that referenced
this pull request
May 18, 2022
…1368) * Fix CNS Reconciling and ASsignmentMode handling for AKS Swift * Fixed the handling of default mode == Dynamic * Incorporate feedback * golint fixes * Fix for whyNoLint: include an explanation for nolint directive (gocritic)
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
…1368) * Fix CNS Reconciling and ASsignmentMode handling for AKS Swift * Fixed the handling of default mode == Dynamic * Incorporate feedback * golint fixes * Fix for whyNoLint: include an explanation for nolint directive (gocritic)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: