Add cleanup network script #1371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
requested changes
May 10, 2022
cni/scripts/cleanupnetwork.ps1
Outdated
| @@ -0,0 +1,76 @@ | |||
| $Global:ClusterConfiguration = ConvertFrom-Json ((Get-Content "c:\k\kubeclusterconfig.json" -ErrorAction Stop) | out-string) | |||
Member
There was a problem hiding this comment.
this works only for k8s cluster.. can we make this script work irrespective of orchestrator?
cni/scripts/cleanupnetwork.ps1
Outdated
| $global:NetworkMode = "L2Bridge" | ||
| $global:ContainerRuntime = $Global:ClusterConfiguration.Cri.Name | ||
| $global:NetworkPlugin = $Global:ClusterConfiguration.Cni.Name | ||
| $global:HNSModule = "c:\k\hns.psm1" |
Member
There was a problem hiding this comment.
we can get this from their github repo directly instead of relying on local disk
cni/scripts/cleanupnetwork.ps1
Outdated
| @@ -0,0 +1,73 @@ | |||
| # ./cleanupnetwork.ps1 -CniName azure | |||
| param ( | |||
| [Parameter(Mandatory=$true)][string]$CniName | |||
cni/scripts/cleanupnetwork.ps1
Outdated
Comment on lines
15
to
17
| if ($global:NetworkPlugin -eq "azure") { | ||
| $networkname = "azure" | ||
| } |
cni/scripts/cleanupnetwork.ps1
Outdated
| } | ||
| } | ||
|
|
||
| if ($global:NetworkPlugin -eq "azure") { |
cni/scripts/cleanupnetwork.ps1
Outdated
|
|
||
| Invoke-WebRequest -Uri https://raw.githubusercontent.com/microsoft/SDN/master/Kubernetes/windows/hns.psm1 -OutFile "c:\hns.psm1" -UseBasicParsing | ||
|
|
||
| $global:NetworkMode = "L2Bridge" |
Member
There was a problem hiding this comment.
is networkmode used anywhere. if not remove it
cni/scripts/cleanupnetwork.ps1
Outdated
| @@ -0,0 +1,43 @@ | |||
| # ./cleanupnetwork.ps1 -CniDirectory c:\k -NetworkName azure | |||
| param ( | |||
| [string]$CniDirectory = "c:\k", | |||
Member
There was a problem hiding this comment.
lets have c:\windows\system32 as default
cni/scripts/cleanupnetwork.ps1
Outdated
| # ./cleanupnetwork.ps1 -CniDirectory c:\k -NetworkName azure | ||
| param ( | ||
| [string]$CniDirectory = "c:\k", | ||
| [Parameter(Mandatory=$true)][string]$NetworkName |
Member
There was a problem hiding this comment.
remove networkname parameter if not used
matmerr
added a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
* add cleanup network script * generalize * generic cwd * loop through with prefix * simplify checks * remove network option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
In the event that HNS gets into a bad state, due to some other service configuring HNS outside of CNI, this script can be used to provide manual mitigation
Issue Fixed:
Requirements:
Notes: