Fix CNS logging #1372
Merged
Fix CNS logging #1372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
requested changes
May 10, 2022
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
if we want to dump (only some) struct fields, maybe cns.CreateNetworkContainerRequest should implement fmt.Stringer?
rbtr
requested changes
May 11, 2022
Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr
approved these changes
May 11, 2022
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
thanks for cleaning this up 🚀
Collaborator
|
hey @camrynl you are welcome to merge. you should also usually have an "enable auto-merge" button so that you don't have to come back later after the CI and approvals are in 🙂 |
Contributor
Author
|
@rbtr noted, thanks! |
rsagasthya
pushed a commit
to rsagasthya/azure-container-networking
that referenced
this pull request
May 18, 2022
* modify cns logging * update to implement stringer interface * fixing linting errors * removing log metadata Co-authored-by: Evan Baker <rbtr@users.noreply.github.com> Co-authored-by: Camryn Lee <camrynlee@microsoft.com> Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
* modify cns logging * update to implement stringer interface * fixing linting errors * removing log metadata Co-authored-by: Evan Baker <rbtr@users.noreply.github.com> Co-authored-by: Camryn Lee <camrynlee@microsoft.com> Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
OrchestratorContext cannot always be unmarshalled due to different orchestrator types, so updating CNS logging to exclude it
Issue Fixed:
Requirements:
Notes: