fix/refactor: [NPM] eliminate struct fields to prevent errors & reduce memory #1374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
reviewed
May 13, 2022
| selectorIpSets[ipset.Metadata.GetPrefixName()] = struct{}{} | ||
| } | ||
|
|
||
| klog.Infof("policy %s has policy selector: %+v", policy.PolicyKey, selectorIpSets) // FIXME remove after debugging |
Contributor
There was a problem hiding this comment.
do you want to remove this line?
Contributor
Author
There was a problem hiding this comment.
gonna fix the bug related to these print statements in a followup PR
|
|
||
| func (dp *DataPlane) getSelectorIPsByPolicyName(policyName string) (map[string]struct{}, error) { | ||
| policy, ok := dp.policyMgr.GetPolicy(policyName) | ||
| func (dp *DataPlane) getSelectorIPsByPolicyName(policyKey string) (map[string]struct{}, error) { |
Contributor
There was a problem hiding this comment.
probably update this func name to getSelectorIPsByPolicyKey
Contributor
Author
There was a problem hiding this comment.
let me fix the followup PR?
| dp.endpointCache[ep.IP] = ep | ||
| klog.Infof("updating endpoint cache to include %s: %+v", ep.IP, ep) // FIXME remove after debugging | ||
| } | ||
| klog.Infof("endpoint cache after refreshing all pod endpoints: %+v", dp.endpointCache) // FIXME remove after debugging |
Contributor
Author
There was a problem hiding this comment.
gonna fix the bug related to these print statements in a followup PR
| // aclPolicyID returns azure-acl-<network policy namespace>-<network policy name> format | ||
| // to differentiate ACLs among different network policies, | ||
| // but aclPolicy in the same network policy has the same aclPolicyID. | ||
| func aclPolicyID(policyNS, policyName string) string { |
Contributor
There was a problem hiding this comment.
No strong opinion, but we can keep this in common policy.go
Contributor
Author
There was a problem hiding this comment.
not adamant either, but prefer to let Linux return an empty string to keep in par with separate dirty cache etc. between OS's
vakalapa
approved these changes
May 13, 2022
rsagasthya
pushed a commit
to rsagasthya/azure-container-networking
that referenced
this pull request
May 18, 2022
…e memory (Azure#1374) * remove Name field from NPMNetworkPolicy * wip moving acl policy id * fix policy key typo for removing Name field * fix lint and log * temp debug logs * another debug log * update a couple UTs
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
…e memory (Azure#1374) * remove Name field from NPMNetworkPolicy * wip moving acl policy id * fix policy key typo for removing Name field * fix lint and log * temp debug logs * another debug log * update a couple UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.