fix: [NPM] fix windows intersection of IPs #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
requested changes
May 17, 2022
vakalapa
reviewed
May 17, 2022
| ) | ||
| } | ||
|
|
||
| if len(policyNetworkRequest.Policies) == 0 { |
Contributor
There was a problem hiding this comment.
why move this check down ?
Contributor
Author
There was a problem hiding this comment.
Added the other check back, but this is a separate check. We can have 1+ setpolicysettings but have 0 policies if there are no setpolicies with the given policyType
huntergregory
commented
May 17, 2022
huntergregory
force-pushed
the
npm-fix-windows-intersection
branch
from
e4cdb51 to
0dd8c55
Compare
matmerr
reviewed
May 19, 2022
npm/pkg/dataplane/ipsets/ipset.go
Outdated
| if set.Kind == HashSet { | ||
| result := make(map[string]struct{}, len(set.IPPodKey)) | ||
| for ip := range set.IPPodKey { | ||
| result[ip] = struct{}{} |
Member
There was a problem hiding this comment.
can we use the set.IPPodKey map directly ignore values instead of creating a map with the same keys?
Contributor
Author
There was a problem hiding this comment.
thinking about this more, there are 2 scenarios:
- when determining which IPs to apply a new policy on, we use the full map
- when updating the IPSets that a pod is a part of, we only check to see if the Pod IP is in the map
The second scenario doesn't require the full map and could use O(1) space, but I'm not sure if this a worthwhile optimization if we already do the O(N) space option for another scenario
matmerr
approved these changes
May 23, 2022
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
* fix windows intersection * test intersection * fix build * separate out children of pod selector and add translate UTs * address comments * address named return comment * optimize space/time for checking if an ip satisfies a pod selector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to never apply policies to endpoints if the policy selector involved a list set. Two changes to enable this:
Other change: fail the dataplane if a non "azure" network is specified or if IPPolicyMode is used, which is unimplemented.