return early if CNI state exist and add some style fixes #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
can you update the title to be descriptive of the change? it becomes the commit message on merge so it is important that it provides immediately useful information. |
ecigar13
changed the title
ecigar13
changed the title
aegal
reviewed
Jun 6, 2022
| return | ||
| } | ||
|
|
||
| if cniStateExists { |
Contributor
There was a problem hiding this comment.
Nit: with this we can remove the below !cniStateExists on line 115
aegal
reviewed
Jun 6, 2022
| } | ||
|
|
||
| if cniStateExists { | ||
| return |
Contributor
There was a problem hiding this comment.
I think we should put a comment here explaining why we return if cniStateExists. Even for folks that have seen this code path before, it's not immediately obvious.
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Jun 29, 2022
* style: format issues * style: lint issues * style: lint issues * style: moved to new block Co-authored-by: Keith Nguyen <keithnguyen@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: