Generate VethName based on podname and namespace in CNI #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamilmani1989
commented
May 16, 2018
cni/network/network.go
Outdated
|
|
||
| k8sPodName := string(podCfg.K8S_POD_NAME) | ||
| if len(k8sPodName) == 0 { | ||
| err = plugin.Errorf("No k8s pod namespace provided.") |
jaer-tsun
reviewed
May 16, 2018
cni/network/network.go
Outdated
| k8sPodName := string(podCfg.K8S_POD_NAME) | ||
| if len(k8sPodName) == 0 { | ||
| err = plugin.Errorf("No k8s pod namespace provided.") | ||
| return err |
Contributor
There was a problem hiding this comment.
just return plugin.Errorf(...)?
jaer-tsun
reviewed
May 16, 2018
| errEndpointInUse = fmt.Errorf("Endpoint is already joined to a sandbox") | ||
| errEndpointNotInUse = fmt.Errorf("Endpoint is not joined to a sandbox") | ||
|
|
||
| OptVethName = "vethname" |
Contributor
There was a problem hiding this comment.
is there a const file to add this to?
Member
Author
There was a problem hiding this comment.
we are following the same thing in ipam/api.go
sharmasushant
suggested changes
May 16, 2018
cni/network/network.go
Outdated
| k8sNamespace := string(podCfg.K8S_POD_NAMESPACE) | ||
| if len(k8sNamespace) == 0 { | ||
| err = plugin.Errorf("No k8s pod namespace provided.") | ||
| return err |
Contributor
There was a problem hiding this comment.
please log here as well
|
|
||
| // Parse network configuration from stdin. | ||
| nwCfg, err = cni.ParseNetworkConfig(args.StdinData) | ||
| if err != nil { |
Contributor
There was a problem hiding this comment.
lets log the err here
sharmasushant
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Generate VethName based on podname and namespace in CNI. The function will generate hash of the key provided and return first 11 characters of hash. The key is "podname.podnamespace" in CNI.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: