Remove azure-vnet-telemetry for windows multitenancy #1430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice for windows multitenancy will be started from cns.
tamilmani1989
requested review from
a team,
ashvindeodhar and
rsagasthya
and removed request for
a team
rbtr
reviewed
Jun 15, 2022
telemetry/telemetrybuffer.go
Outdated
| goto EXIT | ||
| case <-ctx.Done(): | ||
| log.Logf("[Telemetry] received context done event") | ||
| goto EXIT |
Collaborator
There was a problem hiding this comment.
using goto is unusual and makes this harder to understand for me - can we just break? it seems like that would be equivalent.
ashvindeodhar
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vice for windows multitenancy will be started from cns.
Reason for Change:
This PR removes azure-vnet-telemetry binary from windows multitenancy package. Instead, added option in cns to start telemetry service which will receive events from CNI. For windows multitenancy scenario, customer needs to start cns with this option "-ts". eg: ./azure-cns.exe -ts
Issue Fixed:
Requirements:
Notes: