Skip to content

fix: [NPM-WIN] deleted policy may sometimes be applied to a pod #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix: [NPM-WIN] deleted policy may sometimes be applied to a pod #1440

merged 1 commit into from
Jun 23, 2022

Conversation

@huntergregory
Copy link
Contributor

@huntergregory huntergregory commented Jun 21, 2022

Scenario:

  • policy applies to pod A
  • pod A is deleted
  • policy is deleted
  • netpol controller currently keeps trying/failing to delete the policy because pod A's endpoint is not found
  • pod B comes up, and the deleted policy applies to pod B, so incorrect ACLs may be applied on pod B

This PR also cleans up some logs that were slightly confusing to read

@huntergregory huntergregory added the npm Related to NPM. label Jun 21, 2022
@huntergregory huntergregory requested a review from a team as a code owner June 21, 2022 22:04
@huntergregory huntergregory requested review from ck319 and removed request for a team June 21, 2022 22:04
@huntergregory huntergregory changed the title fix: [NPM-WIN] policy may be applied to a pod after the policy is deleted fix: [NPM-WIN] sometimes a deleted policy may be applied to a pod Jun 21, 2022
@huntergregory huntergregory changed the title fix: [NPM-WIN] sometimes a deleted policy may be applied to a pod fix: [NPM-WIN] deleted policy may sometimes be applied to a pod Jun 21, 2022
@huntergregory huntergregory force-pushed the npm-endpoint-not-found branch from fd13d8f to f455751 Compare June 21, 2022 22:28
@huntergregory huntergregory force-pushed the npm-endpoint-not-found branch from f455751 to f068c61 Compare June 22, 2022 01:02
@huntergregory huntergregory enabled auto-merge (squash) June 23, 2022 21:37
@huntergregory huntergregory merged commit 7db16e8 into master Jun 23, 2022
@huntergregory huntergregory deleted the npm-endpoint-not-found branch June 23, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matmerr matmerr matmerr approved these changes

+1 more reviewer

@ck319 ck319 ck319 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

npm Related to NPM.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huntergregory @matmerr @ck319