Skip to content

Fix net-up target in hack Makefile #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Fix net-up target in hack Makefile #1472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5541264
fix net-up target
camrynl Jul 18, 2022
af27d35
space fix
camrynl Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hack/swift/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ vars: ## Show the env vars configured for the swift command
@echo VNET=$(VNET)
@echo CLUSTER=$(CLUSTER)

net-up: azcfg ## Create required swift vnet/subnets
swift-net-up: azcfg ## Create required swift vnet/subnets
$(AZCLI) network vnet create -g $(GROUP) -l $(REGION) --name $(VNET) --address-prefixes 10.0.0.0/8 -o none
$(AZCLI) network vnet subnet create -g $(GROUP) --vnet-name $(VNET) --name nodenet --address-prefixes 10.240.0.0/16 -o none
$(AZCLI) network vnet subnet create -g $(GROUP) --vnet-name $(VNET) --name podnet --address-prefixes 10.241.0.0/16 -o none
Expand All @@ -73,7 +73,7 @@ swift-up: azcfg swift-net-up ## Brings up a swift cluster $name in $SUB/$REGION
@$(MAKE) set-kubeconf

byocni-up: azcfg swift-net-up ## Brings up a swift cluster $name in $SUB/$REGION
$(AZCLI) aks create -n $(CLUSTER)-g $(GROUP) -l $(REGION) \
$(AZCLI) aks create -n $(CLUSTER) -g $(GROUP) -l $(REGION) \
--max-pods 250 \
--node-count 3 \
--network-plugin none \
Expand Down