Update Swift pipeline w byo cluster #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
PR still in progress. Can't convert to draft since I'm testing the pipeline. I'll notify when to review, ty :) |
rbtr
added
enhancement
cns
rbtr
requested changes
Jul 27, 2022
| - task: AzureCLI@1 | ||
| inputs: | ||
| azureSubscription: $(BUILD_VALIDATIONS_SERVICE_CONNECTION) | ||
| azureSubscription: "Azure Container Networking - Test" |
Collaborator
There was a problem hiding this comment.
there is a pipeline var for this Sub, we should use it
cns/azure-cns.yaml
Outdated
| containers: | ||
| - name: cns-container | ||
| image: mcr.microsoft.com/containernetworking/azure-cns:v1.4.7 | ||
| image: mcr.microsoft.com/containernetworking/azure-cns:v1.4.29 |
Collaborator
There was a problem hiding this comment.
Can you revert this? I think this manifest is used by partners, and is unrelated to this change anyway
Collaborator
|
You can also remove this line which currently prevents this test job from running in parallel 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Current e2e tests are utilizing an existing cluster. Each PR waits for the cluster to be available before running tests.
Adding byo cluster feature to pipeline so each PR can run tests in parallel using its own cluster.
Issue Fixed:
Requirements:
Notes: