add cilium and azure-ipam to dropgz image #1483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nddq
reviewed
Jul 20, 2022
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "cniVersion": "0.3.1", | |||
| "name": "cilium", | |||
Member
There was a problem hiding this comment.
we need to change the name here, otherwise Cilium won't invoke cmdDel from azure-ipam. Pinging @tamilmani1989 and @wedaly
Member
There was a problem hiding this comment.
apparently, the name conflicts with another existing chaining plugin's name, which makes the cmdDel flow returns early
Member
There was a problem hiding this comment.
There was a problem hiding this comment.
I think "cilium" will work, actually -- it's "azure" that was causing problems. The chainingapi.DefaultConfigName in the CNI code is "cilium", so setting name="cilium" tells the CNI to skip chaining (which is what we want).
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change:
Issue Fixed:
Requirements:
Notes: