Program IPTables SNAT rules in CNS #1484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nddq
added
cns
rbtr
requested changes
Jul 20, 2022
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
looks good, needs one addition - programming the iptables rules should be gated on a config flag eg: EnableProgramIPTables that we default false. this way we can keep rolling out CNS without expecting this functionality to just start running unexpectedly.
rbtr
requested changes
Jul 21, 2022
cns/configuration/configuration.go
Outdated
| WireserverIP string | ||
| KeyVaultSettings KeyVaultSettings | ||
| MSISettings MSISettings | ||
| DelegatedIPAMUsed bool |
Collaborator
There was a problem hiding this comment.
i think updating this var name was missed
rbtr
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for programming iptables snat rules in CNS, which is a part of delegated IPAM.