Fix CNS Program iptables for delegated IPAM #1499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
requested changes
Aug 1, 2022
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
the conflist needs to exist
Member
Author
For the cns image? |
Collaborator
|
for the dropgz build. you've deleted that unrelated file in this change, it needs to be put back. |
rbtr
reviewed
Aug 2, 2022
cns/restserver/internalapi.go
Outdated
| iptables.RuleExists(iptables.V4, iptables.Nat, iptables.Swift, azureIMDSMatch, snatHostIPJump) { | ||
| // Only check for existence of other iptables rule if SWIFT chain exists. | ||
| if chainExist { | ||
| postroutingToSwiftJumpexist, err := ipt.Exists(iptables.Nat, iptables.Postrouting, "-j", "SWIFT-POSTROUTING") |
Collaborator
There was a problem hiding this comment.
why the change from iptables.Swift to "SWIFT-POSTROUTING"? that really should be a const since it is reused so much
Member
Author
There was a problem hiding this comment.
@tamilmani1989 thinks we should term it like that instead of SWIFT. I can make it a const.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nddq
force-pushed
the
cnsProgramIptables
branch
from
dd5c973 to
5d33af7
Compare
cns/restserver/internalapi.go
Outdated
| return types.FailedToRunIPTableCmd, "[Azure CNS] failed to create SWIFT chain : " + err.Error() | ||
| } | ||
| logger.Printf("[Azure CNS] Append SWIFT Chain to POSTROUTING ...") | ||
| err = ipt.Append(iptables.Nat, iptables.Postrouting, "-j", SwiftChainName) |
Member
There was a problem hiding this comment.
what if this rule exist in this chain? will it return failure if rule exists?
nddq
force-pushed
the
cnsProgramIptables
branch
2 times, most recently
from
823684f to
14742bb
Compare
tamilmani1989
previously approved these changes
Aug 10, 2022
rbtr
previously approved these changes
Aug 11, 2022
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
lgtm, aks-e tests are broken and won't pass
nddq
force-pushed
the
cnsProgramIptables
branch
from
44b2837 to
b208476
Compare
nddq
force-pushed
the
cnsProgramIptables
branch
from
b208476 to
55c35b0
Compare
Collaborator
|
bypassing broken aks-e check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^