Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Aug 2, 2022

Signed-off-by: Evan Baker rbtr@users.noreply.github.com

Reason for Change:

Issue Fixed:

Requirements:

Notes:

  • All necessary Go 1.19 base images have not been published yet; this will stay as draft until the dependencies are available.

@rbtr rbtr added work-in-progress dependencies Dependencies only. go Pull requests that update Go code labels Aug 2, 2022
@rbtr rbtr requested a review from timraymond August 2, 2022 23:26
@rbtr rbtr self-assigned this Aug 2, 2022
@rbtr rbtr force-pushed the go1.19 branch 2 times, most recently from 97b12e6 to a9ae093 Compare August 4, 2022 19:18
@rbtr rbtr marked this pull request as ready for review August 5, 2022 16:42
@rbtr rbtr requested review from a team, matmerr and vakalapa as code owners August 5, 2022 16:42
@rbtr rbtr requested review from thatmattlong and removed request for a team August 5, 2022 16:42
timraymond
timraymond previously approved these changes Aug 9, 2022
Copy link
Member

@timraymond timraymond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... I think this is everywhere? It'd almost be nice to have a GH action to bump Go versions just so we don't miss any place in the future.

@rbtr
Copy link
Collaborator Author

rbtr commented Aug 9, 2022

I think so. An action with paths to sed or something might be nice, but hard to maintain... And even if we automatically update, someone needs to manually update the required PR checks because Github does string matching and the names have the version like Lint(1.18.x, ubuntu-latest)

@timraymond
Copy link
Member

mmm... fair point. We'd likely only run it every six months, where we find that other things have encoded knowledge about the Go version that weren't also updated in the script. Probably more work than it's worth.

Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
@rbtr rbtr merged commit 02c3d76 into Azure:master Aug 24, 2022
@rbtr rbtr deleted the go1.19 branch August 24, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependencies only. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants