Update PR pipeline with ciliume2e #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
splitting swfte2e and ciliume2e into separate templates in the pipeline for future kube-proxy/non kube-proxy cluster scenarios |
rbtr
reviewed
Aug 16, 2022
| configMap: | ||
| name: cns-config | ||
| serviceAccountName: azure-cns | ||
| serviceAccountName: azure-cns |
Collaborator
There was a problem hiding this comment.
you should configure your editor to add trailing newlines on save
nddq
reviewed
Aug 17, 2022
cilium/configmap.yaml
Outdated
| "log-file": "/var/log/cilium-cni.log" | ||
| } | ||
| ], | ||
| "ProgramSNATIPTables" : true |
Member
There was a problem hiding this comment.
This supposes to be in the CNS config btw
Contributor
Author
There was a problem hiding this comment.
hm I can see this new comment now, not sure why I couldn't see the original one
Member
There was a problem hiding this comment.
yeah my bad, I did not hit submit review 🥲
rbtr
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: