fix: Adding a constant hardware address to the veth #1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the hardware address while endpoint creation
go lint errors
updating the IPAddr variable
tamilmani1989
requested changes
Aug 16, 2022
| MacAddress: client.hostVethMac, | ||
| } | ||
|
|
||
| if err := client.netlink.SetOrRemoveLinkAddress(linkInfo, netlink.ADD, netlink.NUD_PERMANENT); err != nil { |
Member
There was a problem hiding this comment.
i meant have to change only for transparent singletenancy and not in other places. Lets update to NUD_PROBE here but not in other places
Contributor
Author
There was a problem hiding this comment.
Okay my bad, just updated it.
| MacAddress: client.hostVethMac, | ||
| } | ||
|
|
||
| if err := client.netlink.SetOrRemoveLinkAddress(linkInfo, netlink.ADD, netlink.NUD_PERMANENT); err != nil { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The hardware address(MAC address) assigned to the veth on the container is not same as the ARP entry in the pod creating pod-to-pod connectivity issue on Ubuntu 22.04 cluster using azure-cni.