pack released version of azure-vnet for CNI Installer #1525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
completing in parts since there isn't a release for azure-ipam yet. later I'd like to discuss how to create the release. |
rbtr
previously approved these changes
Aug 12, 2022
dropgz/build/cni.Dockerfile
Outdated
| ARG VERSION | ||
| ARG OS | ||
| ARG ARCH | ||
| ENV OS=${OS} |
Collaborator
There was a problem hiding this comment.
do you need to reassign the arg to an env variable like this? is it because we use it in a RUN?
Contributor
Author
There was a problem hiding this comment.
oh, just ran make without the env variable assignment and was able to build without those lines. removed it from the pr
rbtr
previously approved these changes
Aug 12, 2022
rbtr
approved these changes
Aug 19, 2022
rbtr
reviewed
Aug 19, 2022
| COPY dropgz . | ||
| COPY --from=azure-ipam /azure-ipam/*.conflist pkg/embed/fs | ||
| COPY --from=azure-ipam /azure-ipam/bin/* pkg/embed/fs | ||
| COPY --from=azure-vnet /azure-container-networking/cni/*.conflist pkg/embed/fs |
Collaborator
There was a problem hiding this comment.
it would be nice to parameterize the conflist copy by $OS and copy to a generic name (eg azure-linux-swift.conflist -> azure-swift.conflist) to make the installation that little bit more platform-agnostic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
update cni.Dockerfile to pack released version of azure-vnet instead of local version.
Issue Fixed:
Requirements:
Notes: